shadowing: stop replicators on topic deletion#28825
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where shadow replicators were not properly stopped when topics were deleted, causing runaway replicators. The fix adds logic to detect when topics are no longer being mirrored and stops their replicators during link configuration updates.
Key changes:
- Added reconciliation logic to stop replicators for deleted topics
- Improved observability by upgrading state-mutating request logs from trace to info level
- Enhanced status output consistency by sorting topics and partitions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/v/cluster_link/link.cc |
Adds tracking and cleanup of replicators for topics that are no longer being mirrored |
src/v/redpanda/admin/services/shadow_link/shadow_link.cc |
Moves logging of state-mutating requests from trace to info level for better observability |
src/v/redpanda/admin/services/shadow_link/converter.cc |
Sorts shadow topics and partition information in status output for consistent reporting |
tests/rptest/tests/cluster_linking_e2e_test.py |
Extends test coverage to verify replicators are properly stopped and can be restarted after topic deletion and re-creation |
Collaborator
CI test resultstest results on build#77284
test results on build#77301
test results on build#77348
|
Contributor
Author
|
/ci-repeat 1 |
Fixes the reconciliation logic to stop the replicators that are no longer needed.
.. for consistent output representation
1ccde65 to
9263bed
Compare
michael-redpanda
approved these changes
Dec 4, 2025
Collaborator
|
/backport v25.3.x |
Collaborator
|
Failed to create a backport PR to v25.3.x branch. I tried: |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the reconciliation logic to stop the replicators that are no longer needed after topic got deleted.
Additionally
Fixes
Backports Required
Release Notes
Bug Fixes