-
Notifications
You must be signed in to change notification settings - Fork 749
ct: cloud topics compaction configs
#29287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
55d2d1c
3b52774
96984c3
55eed32
8b2dd83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,17 +80,20 @@ partitions_memory_reservation::reserved_bytes(size_t total_memory) const { | |
| system_memory_groups::system_memory_groups( | ||
| size_t total_available_memory, | ||
| compaction_memory_reservation compaction, | ||
| cloud_topics_compaction_memory_reservation cloud_topics_compaction, | ||
| bool wasm_enabled, | ||
| bool datalake_enabled, | ||
| bool cloud_topics_enabled, | ||
| partitions_memory_reservation partitions) | ||
| : _compaction_reserved_memory( | ||
| compaction.reserved_bytes(total_available_memory)) | ||
| , _cloud_topics_compaction_reserved_memory( | ||
| cloud_topics_compaction.reserved_bytes()) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. curious why reserved_bytes here isn't a function of the total available memory like the other reservations?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't add a option to configure the reserved memory as a percentage a la
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ahh, that's what I had figured. thanks |
||
| , _partitions_reserved_memory( | ||
| partitions.reserved_bytes(total_available_memory)) | ||
| , _total_system_memory( | ||
| total_available_memory - _compaction_reserved_memory | ||
| - _partitions_reserved_memory) | ||
| - _cloud_topics_compaction_reserved_memory - _partitions_reserved_memory) | ||
|
WillemKauf marked this conversation as resolved.
|
||
| , _wasm_enabled(wasm_enabled) | ||
| , _datalake_enabled(datalake_enabled) | ||
| , _cloud_topics_enabled(cloud_topics_enabled) {} | ||
|
|
@@ -173,7 +176,7 @@ void system_memory_groups::log_memory_group_allocations(seastar::logger& log) { | |
| "total memory minus pre-share reservations: {}, chunk cache: {}, kafka: " | ||
| "{}, rpc: {}, recovery: {}, " | ||
| "tiered storage: {}, admin: {}, data transforms: {}, compaction: {}, " | ||
| "datalake: {}, partitions: {}", | ||
| "cloud topics compaction: {}, datalake: {}, partitions: {}", | ||
| human::bytes(ss::memory::stats().total_memory()), | ||
| human::bytes(total_memory()), | ||
| human::bytes(chunk_cache_max_memory()), | ||
|
|
@@ -184,6 +187,7 @@ void system_memory_groups::log_memory_group_allocations(seastar::logger& log) { | |
| human::bytes(admin_max_memory()), | ||
| human::bytes(data_transforms_max_memory()), | ||
| human::bytes(compaction_reserved_memory()), | ||
| human::bytes(cloud_topics_compaction_reserved_memory()), | ||
| human::bytes(datalake_max_memory()), | ||
| human::bytes(partitions_max_memory())); | ||
| } | ||
|
|
@@ -212,11 +216,14 @@ system_memory_groups& memory_groups() { | |
| compaction.max_limit_pct | ||
| = cfg.storage_compaction_key_map_memory_limit_percent.value(); | ||
| } | ||
| cloud_topics_compaction_memory_reservation cloud_topics_compaction{ | ||
| .max_bytes = cfg.cloud_topics_compaction_key_map_memory.value()}; | ||
| partitions_memory_reservation partitions{ | ||
| .max_limit_pct = cfg.topic_partitions_memory_allocation_percent()}; | ||
| groups.emplace( | ||
| total, | ||
| compaction, | ||
| cloud_topics_compaction, | ||
| wasm, | ||
| datalake_enabled(), | ||
| cloud_topics_enabled(), | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.