rpk: rename decommission --force flag#29369
Merged
Merged
Conversation
To skip-liveness-check. The --force flag is not clear because it implies that it modifies the behavior of the decommissioning, but it just skips checks.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the --force flag to --skip-liveness-check in the rpk redpanda admin brokers decommission command to better clarify its purpose. The flag skips liveness checks rather than forcing decommissioning behavior, and the new name makes this explicit.
Changes:
- Renamed the
forcevariable toskipLivenessCheckthroughout the decommission command implementation - Updated all error messages and help text to reference
--skip-liveness-checkinstead of--force - Deprecated the old
--forceflag while maintaining backward compatibility by binding both flags to the same variable - Fixed a minor formatting issue in the success message (backtick placement)
Collaborator
CI test resultstest results on build#79515
|
malinskibeniamin
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To skip-liveness-check. The --force flag is not clear because it implies that it modifies the behavior of the decommissioning, but it just skips checks.
Please note that I'm not hiding the flag anymore; it is advertised in our help text and in every error message, so it's better to have it present, showing what it does in the help text.
Fixes INC-1056
Example:
Using
--forcewill throw a warning, but still workWith the new flag
Backports Required
Release Notes
Improvements
--forceflag has been deprecated and renamed to--skip-liveness-check.