[v25.3.x] shadowing/write_at_offset_stm: ensure_truncatable API#29446
Merged
bharathv merged 8 commits intoJan 30, 2026
Merged
Conversation
No logical changes, templatized the ghost batch utility on batch type (cherry picked from commit f2653de)
(cherry picked from commit f1df2f1)
(cherry picked from commit c08882b)
Without this the sink may be having a wrong last_replicated_offset from the last inflight replication which has eventually failed. We will end up reset-ing source to wrong offset. (cherry picked from commit 8929eff)
Prefix truncation is a rare op, it is ok to do it inline with replication. Now that we have the ability to do offset only fetches in the client, we don't need a periodic timer loop to do it. (cherry picked from commit 0dcd6a4)
The client was returning an empty batch when the start offset changed. These were getting filtered out in the data_queue, so the notification never reached the replicator and truncation didn’t happen. With this change, an empty batch is treated as valid data. It still gets filtered out by the replicator, but now it triggers prefix truncation This issue was masked until now because there was a periodic truncation async loop that invoked prefix_truncation on a timer. Now that the previous commit removed it, this issue surfaced. (cherry picked from commit f3506e4)
(cherry picked from commit 49fb547)
(cherry picked from commit 75892af)
Collaborator
Author
Retry command for Build#79796please wait until all jobs are finished before running the slash command |
Collaborator
Author
Contributor
|
failures should be gone with #29467 because offset only fetches drive truncation. |
Contributor
|
/dt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29358