[CORE-15272] dt: add basic test for client quota metrics#29457
Merged
Conversation
IoannisRP
force-pushed
the
CORE-15272/quota-metrics
branch
from
1bacdec to
40d4bd6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a ducktape test to verify that client quota metrics exist for all quota rules and types in Redpanda. The test ensures that metrics related to client quotas (throttle time and throughput) are properly exposed through the public metrics endpoint.
Changes:
- Added a new test class
QuotaMetricTestto validate the presence of client quota metrics - Implemented helper methods to retrieve metrics from Redpanda nodes
- Added test coverage for all combinations of quota rules and quota types
pgellert
previously approved these changes
Jan 29, 2026
pgellert
left a comment
pgellert
left a comment
Contributor
There was a problem hiding this comment.
looks good, just noted one simplification opportunity
| ) | ||
|
|
||
|
|
||
| class QuotaMetricTest(RedpandaTest): |
Contributor
There was a problem hiding this comment.
There's already a similar test in client_quota_test.py named test_client_quota_metrics. Could we merge these two / drop one of them / co-locate them to simplify?
Collaborator
CI test resultstest results on build#79834
|
IoannisRP
force-pushed
the
CORE-15272/quota-metrics
branch
from
40d4bd6 to
c888692
Compare
Contributor
Author
|
changes in force-push:
|
IoannisRP
force-pushed
the
CORE-15272/quota-metrics
branch
from
c888692 to
913af8b
Compare
Contributor
Author
|
changes in force-push:
|
pgellert
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: CORE-15272
Add sanity dt test to verify existence of client quota metrics for all the quota rules/types
Backports Required
Release Notes