Skip to content

admin: handle service restart on shard 0 #29519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgellert merged 1 commit into from
Feb 4, 2026
Merged

admin: handle service restart on shard 0 #29519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/v/redpanda/admin/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5113,6 +5113,8 @@ admin_server::restart_service_handler(std::unique_ptr<ss::http::request> req) {

vlog(
adminlog.info, "Restart redpanda service: {}", to_string_view(*service));
co_await restart_redpanda_service(*service);
co_await container().invoke_on(0, [service](admin_server& server) {
return server.restart_redpanda_service(*service);
});

@pgellert pgellert Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this in CI failures on another PR (#29517). It's unclear if this could have any user-visible impact, because I expect that the cross-shard de/allocations would still succeed in production, but there is certainly some possibility for data races, so it is definitely worth backporting.

co_return ss::json::json_return_type(ss::json::json_void());
}