Skip to content

[v25.3.x] kafka/client: fix race condition in direct_consumer_test#29537

Merged
ballard26 merged 1 commit into
redpanda-data:v25.3.xfrom
vbotbuildovich:backport-pr-29527-v25.3.x-575
Feb 5, 2026
Merged

[v25.3.x] kafka/client: fix race condition in direct_consumer_test#29537
ballard26 merged 1 commit into
redpanda-data:v25.3.xfrom
vbotbuildovich:backport-pr-29527-v25.3.x-575

Conversation

@vbotbuildovich

@vbotbuildovich vbotbuildovich commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

Backport of PR #29527

@ballard26 @vbotbuildovich
kafka/client: fix race condition in direct_consumer_test
8760293 
The TestOffsetResetPolicy test can segfault when calling front() on
an empty batch vector. This occurs because its possible for a fetch
response to return just the updated HWM offset without any of the new
batches. This seems to be due to how the consumer_test_mock is written
where the HWM is checked twice, once before generating the batches, and
once after.

(cherry picked from commit b2c964c)
@vbotbuildovich vbotbuildovich added this to the v25.3.x-next milestone Feb 4, 2026
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Feb 4, 2026
@vbotbuildovich

vbotbuildovich commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#80165
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ControllerLogLimitMirrorMakerTests test_mirror_maker_with_limits null integration https://buildkite.com/redpanda/redpanda/builds/80165#019c2b12-1df7-44d7-a307-db841dc2ddf4 FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ControllerLogLimitMirrorMakerTests&test_method=test_mirror_maker_with_limits
NodesDecommissioningTest test_decommission_status null integration https://buildkite.com/redpanda/redpanda/builds/80165#019c2b13-42af-4c4d-974b-d7beaa7bcc9f FLAKY 19/21 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0396, p0=0.5543, reject_threshold=0.0100. adj_baseline=0.1142, p1=0.3167, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=NodesDecommissioningTest&test_method=test_decommission_status
ShardPlacementTest test_upgrade null integration https://buildkite.com/redpanda/redpanda/builds/80165#019c2b12-1df5-4742-b315-74f17b9148d9 FLAKY 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShardPlacementTest&test_method=test_upgrade

@ballard26 ballard26 enabled auto-merge February 5, 2026 15:13
@ballard26 ballard26 merged commit 6e23efb into redpanda-data:v25.3.x Feb 5, 2026
19 checks passed
@piyushredpanda piyushredpanda modified the milestones: v25.3.x-next, v25.3.7 Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ballard26 ballard26 ballard26 approved these changes

Assignees

No one assigned

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Milestone

v25.3.7

Development

Successfully merging this pull request may close these issues.

3 participants

@vbotbuildovich @ballard26 @piyushredpanda