[v26.1.x] Cloud Storage Clients: ABS: Don't send x-ms-version header with batch delete subresponses#30135
Merged
oleiman merged 2 commits intoApr 11, 2026
Conversation
Exposed as cloud_storage_batch_delete_errors counter in remote_probe. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit a8b6084)
Azure rejects batch sub-requests that carry a version header (SubRequestCannotHaveVersionHeader). abs_request_creator::add_auth correctly skips the header when omit_version is true, but the oauth credentials layer (apply_abs_oauth_credentials) was adding it unconditionally. This went unnoticed because batch delete was only tested with Shared Key auth, whose credentials applier does not add the version header. We can't strip the header post-facto because by that time the request is signed. Instead just move the version header setting _out_ of the oauth credentials impl and to abs_client. Also requires a slight adjustment to the credentials test, but we can still have e2e tests that confirm it works. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit ee8c647)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30133