Skip to content

streaming support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Driedas opened this issue Jul 29, 2019 · 2 comments
Closed

streaming support #5

Driedas opened this issue Jul 29, 2019 · 2 comments

Comments

@Driedas
Copy link
Contributor

Driedas commented Jul 29, 2019

Hey,
appreciate the work done on this project, had to slightly change it locally to switch from using byte[] to streaming on the HttpFile class (not a fan of reading files into byte[] for potentially large files).
Would you consider a pull request adding support for streaming in addition of just a byte array on the HttpFile class?
At a glance, maybe something like a StreamingHttpFile class with a Stream property instead of byte[] and in the MultipartFormDataFormatter class right before HttpFile is instantiated check what type the property on the model is (HttpFile or StreamingHttpFile) and based on that instantiate one or the other, reading in the byte array or the stream associated with the file, respectively.

@redplane
Copy link
Owner

redplane commented Aug 1, 2019

Yes, please do a PR, we can do it together :)

Driedas added a commit to Driedas/ApiMultipartFormFormatter that referenced this issue Aug 6, 2019
Driedas added a commit to Driedas/ApiMultipartFormFormatter that referenced this issue Aug 6, 2019
Driedas added a commit to Driedas/ApiMultipartFormFormatter that referenced this issue Aug 6, 2019
Driedas added a commit to Driedas/ApiMultipartFormFormatter that referenced this issue Aug 6, 2019
Driedas added a commit to Driedas/ApiMultipartFormFormatter that referenced this issue Aug 6, 2019
@redplane
Copy link
Owner

Request has been merged into rc-3.0.0 and release-3.0.0.
Closed for now. Any issue please create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants