-
Notifications
You must be signed in to change notification settings - Fork 9
streaming support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, please do a PR, we can do it together :) |
Driedas
added a commit
to Driedas/ApiMultipartFormFormatter
that referenced
this issue
Aug 6, 2019
Driedas
added a commit
to Driedas/ApiMultipartFormFormatter
that referenced
this issue
Aug 6, 2019
Driedas
added a commit
to Driedas/ApiMultipartFormFormatter
that referenced
this issue
Aug 6, 2019
Driedas
added a commit
to Driedas/ApiMultipartFormFormatter
that referenced
this issue
Aug 6, 2019
Driedas
added a commit
to Driedas/ApiMultipartFormFormatter
that referenced
this issue
Aug 6, 2019
Request has been merged into rc-3.0.0 and release-3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey,
appreciate the work done on this project, had to slightly change it locally to switch from using byte[] to streaming on the HttpFile class (not a fan of reading files into byte[] for potentially large files).
Would you consider a pull request adding support for streaming in addition of just a byte array on the HttpFile class?
At a glance, maybe something like a StreamingHttpFile class with a Stream property instead of byte[] and in the MultipartFormDataFormatter class right before HttpFile is instantiated check what type the property on the model is (HttpFile or StreamingHttpFile) and based on that instantiate one or the other, reading in the byte array or the stream associated with the file, respectively.
The text was updated successfully, but these errors were encountered: