Upgrade all dependencies & enforce action.type - #36
Merged
Conversation
- action.type must be a string or Symbol (the latter may or may not be dropped, so test support can also be removed easily) - use npm scripts instead of Makefile - use Babel 6 - use nyc for code coverage and coveralls - test against latest versions of Node LTS - add editorconfig
Contributor
Author
|
CI |
Contributor
|
@JaKXz Sorry I haven't responded to this yet! Been pretty busy lately. This all looks great. |
Contributor
Author
|
@acdlite no worries! life first 👍 I'll reset my last commit. |
Contributor
|
Btw I just sent you an email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
action.typemust be a string or Symbol (the latter may or may not bedropped, so test support can also be removed easily)
nyc(disclaimer: I'm a collaborator onnyc) for code coverage and coveralls.editorconfigmocha.optsand mocha-friendlier file structure [+this way__tests__are not published in the npm package]package.json filesto reduce published lib sizecross-envandrimrafyarn.lock🎉@acdlite @yangmillstheory I got a little carried away (when I noticed
iojsin.travis.yml)... hopefully all of this makes sense - apologies for all of it at once.