Skip to content

Upgrade all dependencies & enforce action.type - #36

Merged
JaKXz merged 6 commits into
redux-utilities:masterfrom
JaKXz:upgrade-everything
Oct 27, 2016
Merged

Upgrade all dependencies & enforce action.type#36
JaKXz merged 6 commits into
redux-utilities:masterfrom
JaKXz:upgrade-everything

Conversation

@JaKXz

@JaKXz JaKXz commented Oct 6, 2016

Copy link
Copy Markdown
Contributor
  • action.type must be a string or Symbol (the latter may or may not be
    dropped, so test support can also be removed easily)
  • use npm scripts instead of Makefile
  • use Babel 6. Closes when to update to babel6 ? #25.
  • use nyc (disclaimer: I'm a collaborator on nyc) for code coverage and coveralls
  • test against latest versions of Node LTS
  • add .editorconfig
  • use mocha.opts and mocha-friendlier file structure [+this way __tests__ are not published in the npm package]
  • fixes minimatch dependency warnings [from mocha 2.x and babel 5.x]
  • specify package files in package.json files to reduce published lib size
  • use cross-platform-friendly commands with cross-env and rimraf
  • add yarn.lock 🎉

@acdlite @yangmillstheory I got a little carried away (when I noticed iojs in .travis.yml)... hopefully all of this makes sense - apologies for all of it at once.

- action.type must be a string or Symbol (the latter may or may not be
dropped, so test support can also be removed easily)
- use npm scripts instead of Makefile
- use Babel 6
- use nyc for code coverage and coveralls
- test against latest versions of Node LTS
- add editorconfig
@JaKXz

JaKXz commented Oct 6, 2016

Copy link
Copy Markdown
Contributor Author

CI is was failing only because npm@2 doesn't like unresolved peer dependencies and eslint-plugin-airbnb-base hasn't updated its peerDependencies, yet: airbnb/javascript#1101

@JaKXz JaKXz closed this Oct 27, 2016
@JaKXz JaKXz reopened this Oct 27, 2016
@acdlite

acdlite commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

@JaKXz Sorry I haven't responded to this yet! Been pretty busy lately. This all looks great.

@JaKXz

JaKXz commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

@acdlite no worries! life first 👍

I'll reset my last commit.

@acdlite

acdlite commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Btw I just sent you an email

@JaKXz
JaKXz merged commit da8af44 into redux-utilities:master Oct 27, 2016
@JaKXz
JaKXz deleted the upgrade-everything branch October 27, 2016 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when to update to babel6 ?

2 participants