Skip to content

Only omit payload if undefined #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Only omit payload if undefined #115

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
901d491
Only omit payload if undefined
jrasky Aug 1, 2016
d84a1fc
Fix tests
jrasky Aug 1, 2016
a12e9ee
Use isUndefined instead of equality test
jrasky Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/__tests__/createAction-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,12 @@ describe('createAction()', () => {

const explictNullAction = createAction(type)(null);
expect(explictNullAction).to.deep.equal({
type
type,
payload: null
});

const baz = '1';
const actionCreator = createAction(type, null, () => ({ bar: baz }));
const actionCreator = createAction(type, undefined, () => ({ bar: baz }));
expect(actionCreator()).to.deep.equal({
type,
meta: {
Expand Down
2 changes: 1 addition & 1 deletion src/createAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function createAction(type, payloadCreator, metaCreator) {
};

const payload = hasError ? args[0] : finalPayloadCreator(...args);
if (!(payload === null || payload === undefined)) {
if (payload !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the lodash function lodash/isUndefined here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but just consider that it does exactly the same thing: https://github.com/lodash/lodash/blob/master/lodash.js#L11878

action.payload = payload;
}

Expand Down