Skip to content

set error to true when payload instanceof Error #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
globalchubby merged 3 commits into from
Sep 27, 2016
Merged

set error to true when payload instanceof Error #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a366ea3
set error to true when payload instanceof Error
xiaohanzhang Sep 22, 2016
6860393
add test
Sep 22, 2016
fc38d4a
fix lint error
Sep 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/__tests__/createAction-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,16 @@ describe('createAction()', () => {
meta: { foo: 'bar' }
});
});

it('set error to true if payloadCreator return an Error object', () => {
const errObj = new TypeError('this is an error');
const actionCreator = createAction(type, () => errObj);
const errAction = actionCreator('invalid arguments');
expect(errAction).to.deep.equal({
type,
payload: errObj,
error: true
});
});
});
});
2 changes: 1 addition & 1 deletion src/createAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function createAction(type, payloadCreator, metaCreator) {
action.payload = payload;
}

if (hasError) {
if (hasError || payload instanceof Error) {
// Handle FSA errors where the payload is an Error object. Set error.
action.error = true;
}
Expand Down