handleAction should accept an empty action i.e., {} - #139
Conversation
|
An action, by definition, must have a type property. There is no such thing as an empty action. A way around this is just to create an action with |
|
Thanks @BerkeleyTrue. This library deals specifically with Flux Standard Actions. The spec says that |
|
True I could create actions like {type:''} @BerkeleyTrue; however, redux itself handles actions of {} just fine so this library which is suppose to be a helper has artificial reduced redux abilities because it does not want to add about 20 chars: '''action.type == null || '''. Also this library used to handle an action of {} just fine until recent changes so to my project this is adding in backwards compatibles since the version number did not indicate breaking changes. If you going to insist on this breaking change then please update the version numbers correctly @yangmillstheory. |
|
@CurtisHumphrey since That being said, I do think it's a valid fix to handle the empty object action since that matches Redux. |
|
Just to clarify the intent of this library: It should be used for FSA-compliant Redux apps. As mentioned above, actions with no If you'd like to retain most of the functionality of this library, but not be FSA-compliant, you're free to fork. |

I write a lot of tests like the following which work until recent changes: