Support namespacing action creators #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangmillstheory
commented
Feb 27, 2017
| @@ -106,16 +99,16 @@ describe('createActions', () => { | |||
| }); | |||
|
|
|||
| it('should honor special delimiters in action types', () => { | |||
| const { 'p/actionOne': pActionOne, 'q/actionTwo': qActionTwo } = createActions({ | |||
| const { p: { actionOne }, q: { actionTwo } } = createActions({ | |||
There was a problem hiding this comment.
This makes this technically a breaking change, so we need a major version bump.
|
It's working but I'm getting a nextjs/webpack "compilation" warning: namespaceActions.js is really missing the export - but it works anyway. |
|
Can you submit a pull request to fix the issue (and file an issue with steps to reproduce)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a pretty standard recursive algorithm to allow for namespacing action creators and action types. Closes #159, #195.
CC: @renato, @tugorez
I originally didn't want this code to be in this library, but several people have asked for it, and I don't think it's unreasonable to include it.