Skip to content

Go back to CommonJS modules for now... #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kevana
Copy link

@kevana kevana commented Dec 30, 2015

...until https://phabricator.babeljs.io/T2817 is resolved.

First crack at the conversion, not entirely sure if this works but I'll verify tomorrow.

}
};

module.exports.ActionTypes = ActionTypes;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this kosher for achieving a default and named exports?

@kevana
Copy link
Author

kevana commented Jan 2, 2016

Fixes #213

@SimenB
Copy link

SimenB commented Jan 11, 2016

@gaearon Could this be looked at? :)

@kevana Tests doesn't need to change, do they?

@kevana
Copy link
Author

kevana commented Jan 11, 2016

@SimenB I don't think it needs any test changes, module behavior should be the same as before. I did add exports.spec.js as a sanity check for exports. I dropped this version into my apps and didn't see any issues but I'm still not completely confident that I got the default and named exports correct.

@gaearon
Copy link
Contributor

gaearon commented Jan 11, 2016

Thanks, but I think I won't support DevTools on IE8.
Even Microsoft ends support for IE < 11 tomorrow.
You can use something like es3ify as a global transformation on your project if you need it.

@kevana
Copy link
Author

kevana commented Jan 12, 2016

I understand completely, it's an easy fix with webpack. Hopefully the really long tail of IE8 traffic starts dying a bit faster...

@SimenB
Copy link

SimenB commented Jan 12, 2016

IE8 will still be supported in enterprise, so my project is stuck with it for now...

In this case we can just use es3ify though, so no real problem. Non-working dev tools in IE8 is a bit sad, but no huge issue

@gaearon
Copy link
Contributor

gaearon commented Jan 13, 2016

Microsoft is not going to support it for anybody, not even enterprise customers. If some enterprises still decide to use unsupported version without security fixes at this point it's their problem.

@kevana
Copy link
Author

kevana commented Jan 13, 2016

The security fixes are their problem but the lost revenue is my problem. It's hard for me to make a business case for dropping support when a material percentage of our customers still use it. Hopefully this pushes the stragglers to finally upgrade.

@gaearon
Copy link
Contributor

gaearon commented Jan 13, 2016

It's a pain for library authors and it's gotta go at some point. I understand your concerns but JS libraries are going this way now that MS doesn't support it, and at this point the only solution we can offer is transpile to ES3 by yourself or use older versions of the tools. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants