-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Tutorials Section: Update code blocks with JS/TS toggle #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0cf9004:
|
cd52509
to
8edf02c
Compare
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 0cf9004 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60dc04c3ca95080008c75a08 😎 Browse the preview: https://deploy-preview-1230--redux-starter-kit-docs.netlify.app |
@phryneas The remark tool removes |
Hmm. Not entirely sure to be honest. That could be a prettier thing maybe? In this case - maybe just return a |
I'm not sure it makes sense to have the code samples in the "TS Quick Start" page be compiled to plain JS, given that the entire point is to have them in TS :) |
@markerikson I was thinking about it, then again the issue said All the snippets, so I thought that's included, anyways pushing the discarded changes 😅 |
look you're supposed to read my mind and realize that when I said "all" I actually meant "all of them that make sense" even though I didn't specify that and wasn't even thinking about this case at the time :) |
2cb46f0
to
cccb19a
Compare
looks good! |
Kicking off #1203
This PR updates the code snippets under Tutorials section to support JS/TS toggles