Skip to content

Integrate the listener middleware into the RTK package #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Moves the listener middleware source into packages/toolkit/listenerMiddleware
  • Adds the docs page for the listener middleware
  • Cleans up the middleware types

- Added public/internal labels on all types
- Removed export of `createListenerEntry`
- Renamed 'S/D' generic args to 'State/Dispatch' for clarity
@github-actions
Copy link

github-actions bot commented Feb 26, 2022

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 14.48 KB (+12.05% 🔺)
1. entry point: @reduxjs/toolkit (esm.js) 12.33 KB (+14.32% 🔺)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 24.23 KB (+6.92% 🔺)
1. entry point: @reduxjs/toolkit/query (esm.js) 19.01 KB (-0.13% 🔽)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 26.53 KB (+6.5% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 21.7 KB (-0.14% 🔽)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 7.27 KB (+27.28% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 7.23 KB (+27.55% 🔺)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 10.12 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 10.55 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.8 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 3.21 KB (0%)
3. createSlice (esm.js) 5.08 KB (+0.96% 🔺)
3. createEntityAdapter (esm.js) 6.44 KB (+2.57% 🔺)
3. configureStore (esm.js) 5.82 KB (+3.05% 🔺)
3. createApi (esm.js) 17.22 KB (-0.13% 🔽)
3. createApi (react) (esm.js) 19.93 KB (-0.11% 🔽)
3. fetchBaseQuery (esm.js) 11.6 KB (-0.21% 🔽)
3. setupListeners (esm.js) 10.46 KB (+0.36% 🔺)
3. ApiProvider (esm.js) 18.56 KB (-0.13% 🔽)

@markerikson markerikson force-pushed the feature/listener-middleware-integration branch 4 times, most recently from 271499e to af83e58 Compare February 26, 2022 22:52
@markerikson markerikson force-pushed the feature/listener-middleware-integration branch from b3772ba to bd0c4fd Compare February 26, 2022 23:10
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2af92f8:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
reduxjs/redux-toolkit Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@markerikson markerikson force-pushed the feature/listener-middleware-integration branch from d4bee34 to 7f95811 Compare February 26, 2022 23:23
@markerikson markerikson force-pushed the feature/listener-middleware-integration branch from 7f95811 to 2af92f8 Compare February 26, 2022 23:35
@markerikson markerikson merged commit 88819e3 into v1.8.0-integration Feb 26, 2022
@markerikson markerikson deleted the feature/listener-middleware-integration branch February 26, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant