Skip to content

Allow passing a createSelector instance to adapter.getSelectors#3481

Merged
markerikson merged 9 commits into
v2.0-integrationfrom
customise-create-selector
May 30, 2023
Merged

Allow passing a createSelector instance to adapter.getSelectors#3481
markerikson merged 9 commits into
v2.0-integrationfrom
customise-create-selector

Conversation

@EskiMojo14

Copy link
Copy Markdown
Collaborator

Fixes #3480

@EskiMojo14 EskiMojo14 added the enhancement New feature or request label May 26, 2023
@EskiMojo14 EskiMojo14 added this to the 2.0 milestone May 26, 2023
@codesandbox

codesandbox Bot commented May 26, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@EskiMojo14 EskiMojo14 changed the base branch from master to v2.0-integration May 26, 2023 15:24
@codesandbox-ci

codesandbox-ci Bot commented May 26, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 99d1cf6:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify

netlify Bot commented May 26, 2023

Copy link
Copy Markdown

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 38a739a
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6470cf3b3ad5f900084a012c
😎 Deploy Preview https://deploy-preview-3481--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

return wrappedSelector as any
}
export const createDraftSafeSelector =
createDraftSafeSelectorCreator(defaultMemoize)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this technically means it isn't using the normal createSelector instance from reselect - is that an issue?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@markerikson

Copy link
Copy Markdown
Collaborator

BuzzLightyearMeme.jpg: "Options objects! Options objects everywhere!"

Comment thread docs/api/createEntityAdapter.mdx Outdated
@markerikson markerikson merged commit d0f73d5 into v2.0-integration May 30, 2023
@EskiMojo14 EskiMojo14 deleted the customise-create-selector branch May 30, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RED-20] Allow passing a createSelector instance to adapter.getSelectors

2 participants