Abort pending requests if the cache entry is removed#5061
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dbb5e65:
|
size-limit report 📦
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
markerikson
force-pushed
the
feature/4942-abort-retries
branch
from
8aee196 to
fc597ba
Compare
markerikson
force-pushed
the
feature/4942-abort-retries
branch
from
fc597ba to
dbb5e65
Compare
aryaemami59
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
module.tsso thatbuildInitiate()is called beforebuildMiddleware(), and then makesgetRunningQueryThunkavailable tobuildMiddlewarecacheCollection.tsto:"_running"postfix when checking if there's still an active subscription to that cache entry. Those indicate a pending request, not a full subscription, and can exist even if there are 0 true subscribers (ref: keep subscription on data while query is running #3709 , BUG: UseLazyXXXQuery Returning undefined On Long Running Queries #3706 )handleUnsubscribe()if there's still an actual cache entry at that time.abort()on itretryConditioncallback, viaextraArgs.baseQueryApi.signal. Added a test to verify it gets marked as aborted if we have aborted the in-flight request.Fixes #4942