experiment: specific entityId type #841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ew. Yeah, I don't think that's worth it atm. (Not an unreasonable request, or a completely unreasonable implementation, but not something I think is justified in being added at this time.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up this morning in the chat with Shrugsy: entityType is never fixed to whatever is actually returned by the
selectIdfunction.This would do that. But at the added type complexity, I guess it won't be worth it. Nonetheless, I gave it a try.
I guess this is one of those "I'll make a PR to document that we tried it and it didn't work out" PRs that we can point to in the future if someone asks for it.
Unless you see it differently and want to get it in @markerikson ? It has some use, it's just questionable if that is worth the overhead.