Redux integration

[kennetpostigo]

Hello,

I'm currently working on a small lib that easily enables people to integrate GraphQL into your redux workflow. Using it would look like this:

// Params it takes in
reachGraphQL(path, query, queryParams = {}, actionCreator)

// In use
reachGraphQL('localhost:3000/graphql',`{
    {
        users{
            name
        }
    }
}`, {}, getUsers);

It depends on the user to utilize redux-thunk when creating a store. Once it executes it dispatches the actionAction creator that was passed in.

I wanted to ask if there is anything that comes to mind that I should consider that I may have over looked.

[gaearon]

It depends on the user to utilize redux-thunk when creating a store.

This is generally not a very good idea. Userland extensions shouldn't rely on user to use a particular third-party middleware. Make your own middleware if you'd like, but don't force user to use Redux Thunk.

[kennetpostigo]

@gaearon, So I should integrate a middleware of my creation into the package? I just thought it would be easier to use one thats already made.

[gaearon]

User might already be using middleware that's incompatible with Redux Thunk.

[gaearon]

Anyway, it's hard to say more because the code snippet you posted does not fully describe the API you implement.

[kennetpostigo]

@gaearon Thank you for the feedback 😄!

[kennetpostigo]

Well, @gaearon currently that is the only exposed part of the API its inner working are like so:

import transport from ('./utils/transport.js');

function reachGraphQL (path, query, queryParams = {}, actionCreator) {
    return async dispatch => {
        try{
            let response = await transport(path, query, queryParams);
            dispatch(actionCreator(response.data));
        } catch (error) {
            console.log(error)
        }
    }
}

The transport import is using isomorphic-fetch in order to create the call.

[gaearon]

I still don't understand the API. Maybe we should wait for README for your project and then we can comment on it :-)

[kennetpostigo]

@gaearon will do.

[kennetpostigo]

@gaearon heres the repo, I just published the beta. http://www.github.com/kennetpostigo/react-reach

[gaearon]

I don't see where you rely on thunk middleware. You dispatch(actionCreator(response.data)) but it doesn't matter whether this action creator is powered by Redux Thunk or just returns an action (or a Promise, or whatever middleware you use). So it seems fine to me.

[kennetpostigo]

Thank you :)