Move exported functions to the top-level src folder#1224
Merged
gaearon merged 2 commits intoreduxjs:masterfrom Jan 12, 2016
Merged
Move exported functions to the top-level src folder#1224gaearon merged 2 commits intoreduxjs:masterfrom
gaearon merged 2 commits intoreduxjs:masterfrom
Conversation
Contributor
|
Can you please reorganize the |
Contributor
Author
|
Done. |
gaearon
added a commit
that referenced
this pull request
Jan 12, 2016
Move exported functions to the top-level src folder
Contributor
|
Thanks. |
Contributor
|
Out in 3.0.6, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here you go. Closes #1223
Also, have you considered depending on external modules for the things left in utils (and possibly compose)? I understand the intuitive appeal of 'zero dependencies', but I think that only really means you get unnecessary code duplication. To plug my own thing as a solution to this problem, i'd be happy to implement all of the utilities in micro-js and also add you to the organization if you'd like.
EDIT: I made a separate PR for the modularization thing. #1225