Drop broken jsnext:main#1327
Closed
taion wants to merge 1 commit intoreduxjs:masterfrom
taion:drop-jsnext-main
Closed
Drop broken jsnext:main#1327taion wants to merge 1 commit intoreduxjs:masterfrom taion:drop-jsnext-main
taion wants to merge 1 commit intoreduxjs:masterfrom
taion:drop-jsnext-main
Conversation
Contributor
|
Shall we do something like https://github.com/rackt/react-redux/pull/256/files? I'm open to distributing a proper ES6 module build. |
Contributor
Author
|
Ah – I didn't see that, and thought #1042 was lingering. Yes, that's a better way to go if you want to distribute an ES2015 build. Easier with Babel 5, too. I'll close this out for now, then. |
Contributor
Author
|
BTW, this is all we have to do with Babel 5: remix-run/react-router#2530. |
This was referenced Feb 5, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1042
Per #1042 (comment), it looks like there's not much benefit in adding a proper ES2015 module build, and the current
jsnext:mainpointing at untranspiled code doesn't accomplish anything other than breaking rollup users.As I recall, there are remain other reasons for continuing to distribute
src/(Flow-related?), so I didn't drop that fromfiles.