Skip to content

Update examples to use functional components #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nickuraltsev
Copy link

No description provided.

)
}
}
const Root = ({ store, history }) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is React able to parse the displayName from named arrow functions? If not it might be good to add adisplayName property to the exported functions for stuff like ReactPerf.

Unless the new ReactPerf that @gaearon is working on handles that differently?

@nickuraltsev
Copy link
Author

@aweary I've just checked that ReactPerf shows the correct names of the functional components in the updated examples. Please see below:

reactperf

@timdorr
Copy link
Member

timdorr commented Sep 4, 2016

This was a part of #1800, which was superceded by #1883. Can you refactor and resubmit now that the examples have changed quite a bit?

@timdorr timdorr closed this Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants