Use eslint-config-react-app instead of rackt for linting #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason we can't get rid of babel-eslint? Are we using decorators anywhere? That's normally what I've had to use it for. |
|
I went ahead and did this by hand since there were merge conflicts. Thanks for the PR for me to copy from! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use eslint-config-react-app
eslint-config-react-app from create-react-app repo instead of
rackt.Enabled linting for the examples which was disabled because of linting mismatch between examples created by create-react-app and redux linter #1928.
Fixed a few lint errors according to the new config.
babel-eslintstill used as peer dependency foreslint-config-react-app