-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Remove Flow types for now #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @acdlite |
Aww I was looking forward to this. Btw let/const should be in soon facebook/flow#431 |
Haha. Help make it happen with the correct signatures :-) |
@gaearon do you have any branch you could publish with your progress there? If you have done any significant progress it would be nice to start from there |
I had one but it descended into pointlessness so it would be easier for you to start fresh.
|
The goal is to get #290 working at least in the minimal way of type checking action/state type validity with |
Cool, will give it a good go tomorrow, thanks for the advice |
I decided in favor of not shipping Flow types in 1.0.
This commit just strips types from the current Flow-friendly codebase (initially worked on in #254).
We will not use features unsupported by Flow (such as
let
orconst
) from now on so it's easy to gradually add Flow types later.The reason I'm removing them is they're too naive and I don't want them to be perceived as the public API (at least not yet). I am ready to add Flow when cases like this are solved. Adding them now is confusing because, for #290 to work, different (more polymorphic) signatures are needed. For example,
Store
type should be parameterized by<MyState, MyAction>
instead ofany
types in the current annotations.