Remove Flow types for now #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided in favor of not shipping Flow types in 1.0.
This commit just strips types from the current Flow-friendly codebase (initially worked on in #254).
We will not use features unsupported by Flow (such as
letorconst) from now on so it's easy to gradually add Flow types later.The reason I'm removing them is they're too naive and I don't want them to be perceived as the public API (at least not yet). I am ready to add Flow when cases like this are solved. Adding them now is confusing because, for #290 to work, different (more polymorphic) signatures are needed. For example,
Storetype should be parameterized by<MyState, MyAction>instead ofanytypes in the current annotations.