-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Remove ES7 from examples #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ES7 from examples #373
Conversation
These examples don't have automated tests AFAIK--did you test them out? =) |
I've tested them manually. Maybe we should open an issue to add test coverage to them. |
I haven't worked much with Travis--how well would it deal with a nested project? |
Don't know. What do you think @gaearon? |
I kind of see how it works.. I'll open an issue on it. |
Awesome, thank you. |
You're welcome! 😉 |
Why no ES7 anymore? |
I believe they're being removed from the examples because not everyone is
|
You could have have ES5, ES6 and ES7 versions of the examples like @gaearon did for React DnD. https://gaearon.github.io/react-dnd/ Pick your poison. |
I think at this point everybody who knows about ES7 features will use them anyway, so no big deal. Maintaining three versions of examples is too big a burden for me at this point. |
counter: PropTypes.number.isRequired | ||
}; | ||
|
||
export default Counter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it works fine to export default class Foo
at the top and still add propTypes after the class declaration.
(Forgive me if I'm wrong, I can't test it out right now.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BadDox I do agree. looks weird but it's correct. maybe send a PR
Here is some features I have removed: