Skip to content

Remove ES7 from examples #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rwillrich
Copy link
Contributor

Here is some features I have removed:

  • Decorators;
  • Bind syntax;
  • Class properties;
  • Object spread.

@quicksnap
Copy link
Contributor

These examples don't have automated tests AFAIK--did you test them out? =)

@rwillrich
Copy link
Contributor Author

I've tested them manually. Maybe we should open an issue to add test coverage to them.

@quicksnap
Copy link
Contributor

I haven't worked much with Travis--how well would it deal with a nested project?

@rwillrich
Copy link
Contributor Author

Don't know. What do you think @gaearon?

@quicksnap
Copy link
Contributor

I kind of see how it works.. I'll open an issue on it.

gaearon added a commit that referenced this pull request Jul 30, 2015
@gaearon gaearon merged commit 5e87896 into reduxjs:breaking-changes-1.0 Jul 30, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 30, 2015

Awesome, thank you.

@rwillrich
Copy link
Contributor Author

You're welcome! 😉

@ms88privat
Copy link

Why no ES7 anymore?

@quicksnap
Copy link
Contributor

I believe they're being removed from the examples because not everyone is
comfortable using non-standard language features--doesn't make them
suitable for general purpose examples.
On Jul 30, 2015 9:20 PM, "ms88privat" [email protected] wrote:

Why no ES7 anymore?


Reply to this email directly or view it on GitHub
#373 (comment).

@mindjuice
Copy link
Contributor

You could have have ES5, ES6 and ES7 versions of the examples like @gaearon did for React DnD. https://gaearon.github.io/react-dnd/

Pick your poison.

@gaearon
Copy link
Contributor

gaearon commented Jul 31, 2015

I think at this point everybody who knows about ES7 features will use them anyway, so no big deal.

Maintaining three versions of examples is too big a burden for me at this point.

counter: PropTypes.number.isRequired
};

export default Counter;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it works fine to export default class Foo at the top and still add propTypes after the class declaration.

(Forgive me if I'm wrong, I can't test it out right now.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BadDox I do agree. looks weird but it's correct. maybe send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants