Don't recommend the use of import * as reducers.
#590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the suggestion to use `import * as reducers` with the recommendation to use `reducers/index.js` and call `combineReducers` there. Updated the code examples accordingly.
|
Thanks! I suggest two tweaks:
|
…e code snippets, as suggested by Dan.
|
Done. |
| #### `App.js` | ||
|
|
||
| ```js | ||
| import { createStore, combineReducers } from 'redux'; | ||
|
|
||
| import * as reducers from './reducers'; | ||
| import reducer from './reducers/index'; | ||
| console.log(reducers); |
There was a problem hiding this comment.
This console.log now can be removed
gaearon
added a commit
that referenced
this pull request
Aug 25, 2015
Don't recommend the use of `import * as reducers`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the suggestion to use
import * as reducerswith the recommendation to usereducers/index.jsand callcombineReducersthere. Updated the code examples accordingly.As discussed here: #473