Fix production FOUC caused by manifest key mismatch#1084
Merged
Conversation
Deploying redwood-sdk-docs with
|
| Latest commit: |
6629258
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf642060.redwood-sdk-docs.pages.dev |
| Branch Preview URL: | https://investigate-fouc.redwood-sdk-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Production builds had a Flash of Unstyled Content (FOUC). Our module IDs use a leading slash while Vite's manifest keys do not, so stylesheet and preload lookups silently found nothing. No CSS links were included in the server-rendered HTML.
Solution
We normalize module IDs to match the manifest key format before lookup. We also added a CSS e2e test that verifies the production HTML includes stylesheet links by loading the page with JavaScript disabled.
Fixes #1083