feat: Respect Vite base for linking asset placeholders#839
Merged
justinvdm merged 1 commit intoredwoodjs:mainfrom Oct 23, 2025
Merged
feat: Respect Vite base for linking asset placeholders#839justinvdm merged 1 commit intoredwoodjs:mainfrom
base for linking asset placeholders#839justinvdm merged 1 commit intoredwoodjs:mainfrom
Conversation
Collaborator
|
Thank you @gching, this looks solid! Merging and releasing |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #837
This PR adds in support for the Vite
basefor the linker for asset placeholders. This is needed since in the current second workers linker build, we are statically replacing asset placeholders to final paths that don't respect thisbasesettingChanges
basetolinkWorkerBundleto prepend if it existsBefore change
With Vite
base=https://example.com/After change
With Vite
base=https://example.com