feat: Remove RWSDK_DEPLOY for cross-platform builds and fix Windows E2E tests#851
Merged
feat: Remove RWSDK_DEPLOY for cross-platform builds and fix Windows E2E tests#851
Conversation
Deploying redwood-sdk-docs with
|
| Latest commit: |
a052738
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2b4432d.redwood-sdk-docs.pages.dev |
| Branch Preview URL: | https://more-windows-fixes.redwood-sdk-docs.pages.dev |
02a1870 to
d806e2f
Compare
added 11 commits
October 31, 2025 03:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces fixes to resolve E2E test failures on Windows CI.
User-Facing Fixes
RWSDK_DEPLOYEnv Var: Replaced the non-portableRWSDK_DEPLOY=1syntax in starter'spackage.jsonscripts with a check againstprocess.env.NODE_ENV. Vite automatically setsNODE_ENVto"production"for builds and"development"for the dev server. This provides a reliable, cross-platform way to determine the build context without requiring extra dependencies. This is also backwards compatible for existing projects created from the starter previously.E2E and CI Fixes
RUNNER~1), while Vite's internals resolved to modern "long" paths (e.g.,runneradmin). This inconsistency broke module alias resolution. The fix was to replacefs.realpathSyncwithfs.realpathSync.nativethroughout the E2E harness, which correctly canonicalizes paths to their long form..yarnrc.ymlfiles by normalizing paths to use forward slashes.execa'sdetached: trueoption severingstdiostreams. The fix was to conditionally set this option tofalseon Windows, restoring error and log output.--reporter=silent,--silent) topnpm,npm, andyarninstall commands to reduce log noise in CI.playground-e2e-tests.ymlworkflow by removing a faulty conditionalshellproperty and relying on runner defaults../scripts/start-windows-debug.sh.CLOUDFLARE_environment variables to the remote session for testing.Current Status
The fixes in this PR have improved the stability of E2E tests on Windows, but several failures remain. Many of these appear to be timeouts, which may be transient. The current test results on Windows are as follows:
pnpm:
npm:
Yarn (Classic):