Update wildcard route pattern in documentation#866
Merged
justinvdm merged 2 commits intoredwoodjs:mainfrom Nov 6, 2025
Merged
Conversation
The example for wildcards should've probably used `*` character here.
Collaborator
|
Thanks @valscion! |
justinvdm
reviewed
Nov 6, 2025
sdk/src/runtime/lib/router.ts
Outdated
| * - Static: /about, /contact | ||
| * - Parameters: /users/:id, /posts/:postId/edit | ||
| * - Wildcards: /files/*, /api/star/download | ||
| * - Wildcards: /files/*, /api/*/download |
Collaborator
There was a problem hiding this comment.
Ah, on second thought, I think I see why it's like this :D this inadvertently ends the comment block (*/). Maybe we keep it like this then? I guess there's a way to escape it?
Contributor
Author
There was a problem hiding this comment.
Haha, right! Ok so yeah, that's indeed difficult. Maybe *\/ is the way to go?
But maybe there's some other tool that would break if this was the case. How can we test it?
Collaborator
There was a problem hiding this comment.
I think if e2e passing we good! Still good callout though, if we find this happens to interact badly with something (maybe a vite plugin transform or somethiing?), we can change this back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for wildcards should've probably used
*character here.Noticed this one when looking at the diff from #860