-
Notifications
You must be signed in to change notification settings - Fork 7
debug checks are always enabled because ndebug
is no longer supported by rustc
#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Jun 5, 2018
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0. This adds a duplicate dependency on `unreachable` until I have time to fork `ordered-float`, but it's a tiny dependency so we don't care.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Jun 6, 2018
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0. This adds a duplicate dependency on `unreachable` until I have time to fork `ordered-float`, but it's a tiny dependency so we don't care.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Jun 6, 2018
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0. This adds a duplicate dependency on `unreachable` until I have time to fork `ordered-float`, but it's a tiny dependency so we don't care.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Jun 6, 2018
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0.
3 tasks
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this issue
Jun 6, 2018
Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0.
bors-servo
pushed a commit
to servo/servo
that referenced
this issue
Jun 6, 2018
Update dependencies to use new_debug_unreachable Because reem/rust-debug-unreachable#6 makes `debug_unreachable` enable debug checks even in release builds since Rust 1.0. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they only change external code <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20935) <!-- Reviewable:end -->
mbrubeck
added a commit
to mbrubeck/swc
that referenced
this issue
Oct 26, 2022
The `debug_unreachable` crate is broken and unmaintained; see reem/rust-debug-unreachable#6
mbrubeck
added a commit
to mbrubeck/swc
that referenced
this issue
Oct 26, 2022
The `debug_unreachable` crate is broken and unmaintained; see reem/rust-debug-unreachable#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rust-lang/rust#22980 replaced
cfg(ndebug)
withcfg(not(debug_assertions))
. The compiler no longer setscfg(ndebug)
in release builds.The text was updated successfully, but these errors were encountered: