Adding image filtering for fbc_operations requests#514
Merged
lipoja merged 1 commit intorelease-engineering:masterfrom May 2, 2023
Merged
Adding image filtering for fbc_operations requests#514lipoja merged 1 commit intorelease-engineering:masterfrom
lipoja merged 1 commit intorelease-engineering:masterfrom
Conversation
chandwanitulsi
previously approved these changes
Apr 28, 2023
Contributor
chandwanitulsi
left a comment
chandwanitulsi
left a comment
There was a problem hiding this comment.
If preferred you can update https://github.com/release-engineering/iib/blob/master/tests/test_web/test_api_v1.py#L163 to test this addition, but its not needed for approval.
Thanks for catching and improving this :)
lipoja
force-pushed
the
add_fbc_operation_index_filter
branch
from
1cb7dc0 to
53a4c88
Compare
lipoja
force-pushed
the
add_fbc_operation_index_filter
branch
from
53a4c88 to
c971a09
Compare
Contributor
Author
|
@chandwanitulsi Added tests, please review |
Collaborator
|
Great catch, Jan! |
yashvardhannanavati
approved these changes
Apr 28, 2023
chandwanitulsi
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.