Enable celery task deduplication#558
Merged
lipoja merged 1 commit intorelease-engineering:masterfrom Aug 8, 2023
Merged
Conversation
lipoja
requested review from
MichalZelenak,
chandwanitulsi and
yashvardhannanavati
lipoja
force-pushed
the
enable_deduplication
branch
from
dff80da to
f0fde65
Compare
MichalZelenak
previously approved these changes
Aug 8, 2023
yashvardhannanavati
requested changes
Aug 8, 2023
Collaborator
yashvardhannanavati
left a comment
yashvardhannanavati
left a comment
There was a problem hiding this comment.
Could you please add the missing type?
worker_deduplicate_successful_tasks: bool = True
Before each task execution, instruct the worker to check if this task is a duplicate message. Deduplication occurs only with tasks that have the same identifier, enabled late acknowledgment, were redelivered by the message broker and their state is SUCCESS in the result backend. [CLOUDDST-19499]
lipoja
force-pushed
the
enable_deduplication
branch
from
f0fde65 to
3aa2bde
Compare
Contributor
Author
Added, please review again |
yashvardhannanavati
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before each task execution, instruct the worker to check if this task is a duplicate message.
Deduplication occurs only with tasks that have the same identifier, enabled late acknowledgment, were redelivered by the message broker and their state is SUCCESS in the result backend.
[CLOUDDST-19499]