Backup index.db to prevent opm bug consequence#635
Merged
MichalZelenak merged 1 commit intorelease-engineering:masterfrom Mar 8, 2024
Merged
Backup index.db to prevent opm bug consequence#635MichalZelenak merged 1 commit intorelease-engineering:masterfrom
MichalZelenak merged 1 commit intorelease-engineering:masterfrom
Conversation
MichalZelenak
force-pushed
the
remove_retry
branch
2 times, most recently
from
989f277 to
bd2db1b
Compare
MichalZelenak
force-pushed
the
remove_retry
branch
6 times, most recently
from
bde40dc to
dfc3d3c
Compare
lipoja
approved these changes
Mar 6, 2024
MichalZelenak
changed the title
Contributor
Author
|
Logs from worker with implemented workaround (local run), used image is the copy of the image that was present in the failed build. |
MichalZelenak
force-pushed
the
remove_retry
branch
from
9485324 to
a81a475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA issue: CLOUDDST-20957
Related OPM bug: OCPBUGS-30214
Method
opm_registry_add_fbccalls `_opm_registry_add.The first time method
opm_registry_add_fbccalls_opm_registry_add,_opm_registry_addfails. This failure is the correct expected behavior, however, the OPM command modifies the database file (should not be modified on an error).As this
_opm_registry_addmethod has the retry decorator, it is triggered again, now failing with a different error (the error is a consequence of the database modification in the previous run attempt). Only the second error (wrong one) is propagated to the parentopm_registry_add_fbcmethod. (As we have the retry decorator with theopm_registry_add_fbcmethod, this whole process is repeated).As a result, the error, resulting from running the OPM command on the modified database file, is propagated into the state_reason.
In the solution, I propose a workaround, which creates a backup of the database file, then runs the OPM command and uses backup on command failure.