Reimplement naturalsize as part of pubtools-pulplib [RHELDST-29440] #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalHaluza
force-pushed
the
absorb_humanize
branch
3 times, most recently
from
7e7127e to
e804175
Compare
This commit pulls out the `naturalsize()` function from humanize module and reimplements its equivalent in pubtools-pulplib. The humanize module is then removed from dependencies as it's not used anywhere else. This is done to reduce the dependency bloat and make the RPM packaging easier on RHEL 9 which doesn't ship python-humanize.
MichalHaluza
force-pushed
the
absorb_humanize
branch
from
e804175 to
58b411d
Compare
rajulkumar
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls out the
naturalsize()function from humanize module and reimplements its equivalent in pubtools-pulplib. The humanize module is then removed from dependencies as it's not used anywhere else. This is done to reduce the dependency bloat and make the RPM packaging easier on RHEL 9 which doesn't ship python-humanize.