Skip to content

Remove unused default server entries #11615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove unused default server entries #11615

merged 1 commit into from
Jun 18, 2024

Conversation

markdalgleish
Copy link
Member

With the runtime packages moving our of this repo, we're removing their accompanying default server entry files.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: db95bc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 added the v7 label Jun 14, 2024
markdalgleish
markdalgleish commented Jun 18, 2024
View reviewed changes
packages/remix-dev/config.ts
"@react-router/node",
];
let formattedList = disjunctionListFormat.format(serverRuntimes);
if (!deps["@react-router/node"]) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the only built-in runtime package so we can simplify the code a lot.

@markdalgleish markdalgleish merged commit 2d34a7e into v7 Jun 18, 2024
7 of 8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/remove-unused-default-entries branch June 18, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdalgleish @brophdawg11