feat: turbo-stream v3 #12945

jacob-ebey · 2025-02-03T20:58:25Z

No description provided.

changeset-bot · 2025-02-03T20:58:31Z

🦋 Changeset detected

Latest commit: 66d5af8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11

Did a quick code review - can pull it down and do some app testing too later today or tomorrow if you'd like me too also

brophdawg11 · 2025-02-11T19:30:18Z

.changeset/turbo-v3.md

@@ -0,0 +1,6 @@
+---
+"integration": minor


I dont think we need entries for this

Suggested change

"integration": minor

brophdawg11 · 2025-02-11T19:44:13Z

packages/react-router/lib/server-runtime/server.ts

@@ -230,6 +230,10 @@ export const createRequestHandler: CreateRequestHandlerFunction = (
      );
    }

+    if (!response) {
+      return new Response("Unknown Server Error", { status: 500 });


We can probably run this through the same utility we use elsewhere

Suggested change

return new Response("Unknown Server Error", { status: 500 });

let error = new Error('Unhandled request')

return returnLastResortErrorResponse(error, serverMode);

brophdawg11 · 2025-02-11T19:45:23Z

packages/react-router/lib/server-runtime/single-fetch.ts

@@ -327,44 +327,22 @@ export function encodeViaTurboStream(

  return encode(data, {
    signal: controller.signal,
+    redactErrors:
+      serverMode === ServerMode.Development ? false : "Unexpected Server Error",


Nice! This is a great new feature for turbo-stream 👍

ngbrown · 2025-02-12T03:06:17Z

Is this backwards compatible with turbo-stream v2? i.e. if the server has updated to v3 but the client hasn't reloaded the window and is still on v2 and makes a data request, what will happen?

jacob-ebey · 2025-02-12T19:54:31Z

Is this backwards compatible with turbo-stream v2? i.e. if the server has updated to v3 but the client hasn't reloaded the window and is still on v2 and makes a data request, what will happen?

It is not a BW compat data format.

frolic · 2025-03-16T13:57:38Z

any update on landing this?

aaschlote · 2025-04-17T13:44:19Z

any updates when this will be merged?

brophdawg11 · 2025-04-17T14:58:34Z

No updates at the moment - we're still noodling on this internally. This would be a breaking change if we adopted it and with RSC on the horizon it may not be worth it since we'll likely be replacing turbo-stream with the RSC wire format with that work.

remorses · 2025-04-18T13:46:18Z

I prefer the turbo-stream format compared to RSC, turbo-stream supports Error instances, async iterables, buffers and a lot more that RSC does not.

I think the best approach would be to embed the RSC stream inside turbostream, as a text stream (which is already supported). This way react-router can continue to extend the loader serialization format and not depend on React for these decisions.

jacob-ebey · 2025-04-24T01:23:39Z

Someone should audit the turbo-stream re-write... It is, after-all, a weekend project that only a handful of people have glanced at.

remorses · 2025-05-27T10:38:34Z

It seems that RSC supports async generators now which was one of the main reasons I preferred turbostream
https://stackblitz.com/edit/stackblitz-starters-thuag2gq?file=app%2Fpage.tsx

MichaelDeBoey · 2025-05-27T13:56:50Z

This would be a breaking change

@brophdawg11 @jacob-ebey Wasn't the whole idea of using turbo-stream that it would be an implementation detail?
I even recall somewhere in the docs saying that we shouldn't rely on it in our own projects, just because of this reason.

remorses · 2025-05-27T13:59:22Z

@MichaelDeBoey I guess the breaking change is a problem for the browser, a client of one version no longer works with a server with another version

MichaelDeBoey · 2025-05-27T14:31:35Z

@remorses I don't see how that would be a problem tbh.
The dev will update RR, which will update turbo-stream.

Once a new deploy of the app is happening, this is going to update both client and server, no?
Or am I missing something here? 🤔

remorses · 2025-05-27T14:34:24Z

It's a problem when client and server are deployed separately, or when an user tries to submit a form when the page was using a previous react-router version compared to the new server deployment

MichaelDeBoey · 2025-05-27T15:44:32Z

@remorses The server is the one providing all the client files, so it's not really a use-case that both are deployed separately I think?

ngbrown · 2025-05-27T19:26:04Z

@MichaelDeBoey The server and client files on the server are deployed simultaneously. But clients that had already loaded the page before the server update would now have an incompatible client. They would need a full page reload to download the current version of client-side js.

So if the user was about to have some dynamic content show up or submit a form and the server was updated with an incompatible version of turbo-stream, then the interaction could potentially break.

On my application, where the clients don't have to do full page reloads very often, the client version can get old. I do intend on showing a notification that there is a new version, so please refresh, but the client would be broken in even showing that message if the endpoint used to convey that information used turbo-stream and the client suddenly couldn't decode the response. A scheduled time to switch over would be ideal in that case.

MichaelDeBoey · 2025-05-27T22:05:03Z

@ngbrown I understand your explanation, but couldn't that be the case for a lot more implementation details?

Say we change how something on the server is handled, in your explanation that would always be a breaking change.
This would mean we would need to release major release a lot.

Not sure how the team is looking at this, but unless there are other concerns that I'm currently missing (which could probably be the case), this PR is just a change in implementation details, which shouldn't cause a breaking change in my opinion.

ngbrown · 2025-05-27T23:12:05Z

@MichaelDeBoey But there were a lot of major releases like that, but they were all enabled one-by-one with future flags. So in the end, the breaking change could be rolled out in a controlled way, and the major version of the framework didn't have to increment each time.

jacob-ebey · 2025-05-28T13:49:53Z

RSC is coming.

feat: turbo-stream v3

dd58ad9

remix-cla-bot bot added the CLA Signed label Feb 3, 2025

update version

62f87ab

jacob-ebey marked this pull request as ready for review February 4, 2025 17:39

jacob-ebey added 7 commits February 4, 2025 09:40

Create turbo-v3.md

bf5729d

update error redaction to match existing behavior

a24b23a

fix lockfile

76fad7d

fix: ensure deferred promises settle

bb408d5

oops

5d5519a

update tests that count scripts

d645caa

add nonce to finalization script

b91d194

brophdawg11 approved these changes Feb 11, 2025

View reviewed changes

steal fetch for the test to not rely on playwright network interception

d5af379

jacob-ebey closed this Feb 12, 2025

jacob-ebey reopened this Feb 12, 2025

jacob-ebey added 5 commits February 12, 2025 14:33

feat: add future flag

fbd98e4

feat: add future flag

f5cc98e

fix build

8a7e37d

update types

696f53e

remove lint rule

66d5af8

bjohn465 mentioned this pull request Feb 23, 2025

Map and Set entries reversed on page hydration #13093

Closed

kevlened mentioned this pull request Mar 27, 2025

Bug: React Router 7 Loader Fails When Response Contains Invalid Date Objects #13308

Open

aaschlote mentioned this pull request Apr 17, 2025

Ignore sentry errors digitalservicebund/a2j-rechtsantragstelle#1951

Merged

jacob-ebey closed this May 28, 2025

MichaelDeBoey deleted the turbo-stream-v3 branch May 28, 2025 15:31

	return new Response("Unknown Server Error", { status: 500 });
	let error = new Error('Unhandled request')
	return returnLastResortErrorResponse(error, serverMode);

Uh oh!

feat: turbo-stream v3 #12945

feat: turbo-stream v3 #12945

Uh oh!

Conversation

jacob-ebey commented Feb 3, 2025

Uh oh!

changeset-bot bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

brophdawg11 left a comment

Choose a reason for hiding this comment

Uh oh!

brophdawg11 Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

brophdawg11 Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

ngbrown commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacob-ebey commented Feb 12, 2025

Uh oh!

frolic commented Mar 16, 2025

Uh oh!

aaschlote commented Apr 17, 2025

Uh oh!

brophdawg11 commented Apr 17, 2025

Uh oh!

remorses commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacob-ebey commented Apr 24, 2025

Uh oh!

remorses commented May 27, 2025

Uh oh!

MichaelDeBoey commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

remorses commented May 27, 2025

Uh oh!

MichaelDeBoey commented May 27, 2025

Uh oh!

remorses commented May 27, 2025

Uh oh!

MichaelDeBoey commented May 27, 2025

Uh oh!

ngbrown commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelDeBoey commented May 27, 2025

Uh oh!

ngbrown commented May 27, 2025

Uh oh!

jacob-ebey commented May 28, 2025

Uh oh!

Uh oh!

changeset-bot bot commented Feb 3, 2025 •

edited

Loading

ngbrown commented Feb 12, 2025 •

edited

Loading

remorses commented Apr 18, 2025 •

edited

Loading

MichaelDeBoey commented May 27, 2025 •

edited

Loading

ngbrown commented May 27, 2025 •

edited

Loading