-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Normalize dirent
entry path across node versions when generating SRI manifest
#13591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize dirent
entry path across node versions when generating SRI manifest
#13591
Conversation
🦋 Changeset detectedLatest commit: 2613db5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @pawelblaszczyk5, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
4f597b9
to
779a1d1
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
What version doesn't |
Here's the exact versions that introduced it from node fs docs |
Thanks! I'll get this merged once CI runs |
🤖 Hello there, We just published version Thanks! |
Fixes #13590
entry.path
onDirent
is deprecated since a few versions and removed as of Node version 24 nodejs/node#55548https://nodejs.org/docs/latest-v23.x/api/fs.html#direntpath
Since RR declares engines as working with any minor/patch version above 20.x.x - I can’t just directly use the
parentPath
which is recommended now. I normalize it so it works also in few minors that havedirent.path
but don't havedirent.parentPath
. Also a bit of gymnastics for TS is needed because installed version of types for node doesn’t include theparentPath