Fix RSC fetcher.load
#13709
Fix RSC fetcher.load
#13709
Conversation
|
| @@ -2258,7 +2258,6 @@ export function createRouter(init: RouterInit): Router { | |||
| return; | |||
| } | |||
|
|
|||
| let match = getTargetMatch(matches, path); | |||
There was a problem hiding this comment.
In the fog of war case, this match is completely ignored and is reassigned once route discovery is done. In an RSC world, if the the root route doesn't have a path, this line throws an error even though its result would never have been used.
To fix this, the creation of this match variable is delayed until after route discovery has completed and we know for a fact we have valid matches. This also means we no longer pass it as an argument to handleFetcherLoader and handleFetcherAction.
| if (!match.route.action && !match.route.lazy) { | ||
| let error = getInternalRouterError(405, { | ||
| method: submission.formMethod, | ||
| pathname: path, | ||
| routeId: routeId, | ||
| }); | ||
| setFetcherError(key, routeId, error, { flushSync }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The detectAndHandle405Error function has been inlined now that this logic is only needed in a single place.
No description provided.