Skip to content

Make uWebSockets.js required for node-serve#11311

Merged
mjackson merged 1 commit into
mainfrom
mjackson/node-serve-uws-dependency
Apr 30, 2026
Merged

Make uWebSockets.js required for node-serve#11311
mjackson merged 1 commit into
mainfrom
mjackson/node-serve-uws-dependency

Conversation

@mjackson
Copy link
Copy Markdown
Member

node-serve imports uWebSockets.js at module load and serve() creates a uWebSockets app directly, so the transport is required for the package to work.

  • Moves uWebSockets.js from optionalDependencies to dependencies for @remix-run/node-serve
  • Updates the lockfile so installs treat the native transport as required
  • Removes the optional-dependency install warning from the README
  • Adds a patch change file for the corrected install behavior

@github-actions
Copy link
Copy Markdown
Contributor

Preview Build Available

A preview build has been created for this PR. You can install it using:

pnpm install "remix-run/remix#preview/pr-11311&path:packages/remix"

This preview build will be updated automatically as you push new commits.

@mjackson mjackson merged commit 7cb6c73 into main Apr 30, 2026
27 checks passed
@mjackson mjackson deleted the mjackson/node-serve-uws-dependency branch April 30, 2026 21:43
@github-actions
Copy link
Copy Markdown
Contributor

The preview branch preview/pr-11311 has been deleted now that this PR is merged/closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants