-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add canonical remix export manifest #11392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 43 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
9294ec7
Add regex-pattern manifest with validation tests
brophdawg11 949c9cf
Phase 2: teach generate-remix to read manifest for canonical paths
brophdawg11 28db554
Update demo imports to canonical remix paths
brophdawg11 cbb9a94
Fix bug in sse demo client entry asset
brophdawg11 14ef5be
Phase 3: use manifest for canonical paths in docs generation
brophdawg11 eca6d69
Extract shared manifest logic into scripts/utils/manifest.ts
brophdawg11 5984b92
Rename resolveRemixPath to mapToRemixPackage; include remix/ prefix
brophdawg11 0d97255
Simplify mapToRemixPackage: use split('/') for subpath extraction
brophdawg11 08a3425
Simplify mapToRemixPackage to a one-liner
brophdawg11 7a2810c
Fold readWorkspacePackageNames into buildSpecifierToRemixPath
brophdawg11 7385e87
Fold readManifest into buildSpecifierToRemixPath
brophdawg11 60d5ebf
Fix docs sidebar showing remix/router/routes instead of remix/routes
brophdawg11 3fc4299
Format and regex updates
brophdawg11 095595b
Update ui demos and template imports to canonical remix paths
brophdawg11 77cf16c
Fix regex and update change file
brophdawg11 ea77c33
Update outdated remix import paths in JSDoc and code-gen
brophdawg11 f957f96
Update all markdown docs to canonical remix import paths
brophdawg11 0a6998f
Update change file with all renamed remix exports
brophdawg11 af3f4fa
Flatten and sort change file bullets alphabetically
brophdawg11 f903f08
More updates
brophdawg11 9c5f0ff
Update README H1 headings to canonical remix import paths
brophdawg11 c830a0c
Fix test
brophdawg11 5d88f64
Merge origin/ integrate readme and generate-remix changesmain
brophdawg11 bb1fb07
Add deprecated legacy alias exports for backward compatibility
brophdawg11 a9cf07d
Fix packageDirName out-of-scope type error in generate-remix
brophdawg11 ca38a4f
Preserve legacy exports for now
brophdawg11 b56a8d8
Co-locate generated export source files with their README
brophdawg11 38ccbc0
build: update remix package (generate-remix)
brophdawg11 efc0d63
Revert demos/* import legacy aliases cover old pathschanges
brophdawg11 a040813
Revert packages/ui/demo and docs/src/server import changes
brophdawg11 b488d3d
Revert source package README import changes
brophdawg11 48baf22
build: update remix package
remix-run-bot a4bff72
Revert JSDoc and code-gen import path changes
brophdawg11 61421ea
Revert doctor.test.ts to match reverted code-gen
brophdawg11 e12b13c
Revert "Co-locate generated export source files with their README"
brophdawg11 90682b4
regen remix package
brophdawg11 e6c75b3
Revert .changes file import path edits
brophdawg11 94d6da2
Update change file
brophdawg11 8ad4de2
Place READMEs at legacy alias paths to match origin/main layout
brophdawg11 81fe3ca
Remove @deprecated JSDoc tags from legacy alias exports
brophdawg11 0120290
Sort legacy alias exports into alphabetical order in package.json
brophdawg11 d322644
Name stubs after sub-packages, map canonical paths in package.json ex…
brophdawg11 6e66123
Convert bookstore demo to canonical remix export paths
brophdawg11 fdd4b6c
refactor: make generate-remix fully manifest-driven, remove buildLega…
brophdawg11 43465c4
refactor: remove dead isLegacyAlias/isLegacyExportPath helpers
brophdawg11 58a3149
refactor: make buildSpecifierToRemixPath order-independent
brophdawg11 6ed2477
fix: skip legacy alias exports when building docs sidebar entries
brophdawg11 1b77a14
chore: convert all demos to canonical remix export paths
brophdawg11 9fa18ba
chore: convert docs site to canonical remix export paths
brophdawg11 347f092
chore: convert all README and change files to canonical remix export …
brophdawg11 afb12da
revert: restore .changes/*.md files to pre-readme-conversion state
brophdawg11 7587bb5
chore: convert source JSDoc comments to canonical remix export paths
brophdawg11 a4b958a
chore: convert template to canonical remix export paths
brophdawg11 57e7a30
feat: add manifest test for missing workspace packages; update add-pa…
brophdawg11 2e3ef08
Update skill
brophdawg11 06b7f58
chore: update package README H1s to canonical remix export names
brophdawg11 b08cd1c
Fix README titles for docs and GitHub
mjackson f5e1493
Handle Windows README line endings
mjackson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
demos/bookstore/app/actions/auth/forgot-password/controller.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import * as path from 'node:path' | ||
| import * as url from 'node:url' | ||
| import { buildSpecifierToRemixPath } from '../../../scripts/utils/manifest.ts' | ||
|
|
||
| const __dirname = path.dirname(url.fileURLToPath(import.meta.url)) | ||
| const packagesDir = path.resolve(__dirname, '../../../packages') | ||
|
|
||
| const specifierMap = buildSpecifierToRemixPath(packagesDir) | ||
|
|
||
| /** | ||
| * Maps a full npm specifier (e.g. `@remix-run/fetch-router` or | ||
| * `@remix-run/session/cookie-storage`) to its canonical `remix/*` import path | ||
| * (e.g. `remix/router` or `remix/session-storage/cookie`). | ||
| * | ||
| * Falls back to the mechanical `remix/<short-name>` path when no manifest | ||
| * entry covers the specifier. | ||
| */ | ||
| export function mapToRemixPackage(specifier: string): string { | ||
| return specifierMap.get(specifier) ?? specifier.replace(/^@remix-run\//, 'remix/') | ||
| } | ||
|
|
||
| export function hasRemixPackage(specifier: string): boolean { | ||
| return specifierMap.has(specifier) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| Updated the `remix` package to use domain-oriented exports, no longer always mapping | ||
| 1:1 to underlying `@remix-run/*` packages. 1:1 package exports are left to ease migrations, | ||
| but are marked deprecated and will be removed before a Remix 3.0.0 stable release. | ||
|
|
||
| Changed package mappings: | ||
|
|
||
| - `remix/async-context-middleware` → `remix/middleware/async-context` | ||
| - `remix/auth-middleware` → `remix/middleware/auth` | ||
| - `remix/compression-middleware` → `remix/middleware/compression` | ||
| - `remix/cop-middleware` → `remix/middleware/cop` | ||
| - `remix/cors-middleware` → `remix/middleware/cors` | ||
| - `remix/csrf-middleware` → `remix/middleware/csrf` | ||
| - `remix/data-table-mysql` → `remix/data-table/mysql` | ||
| - `remix/data-table-postgres` → `remix/data-table/postgres` | ||
| - `remix/data-table-sqlite` → `remix/data-table/sqlite` | ||
| - `remix/fetch-router` → `remix/router` | ||
| - `remix/fetch-router/routes` → `remix/routes` | ||
| - `remix/file-storage-s3` → `remix/file-storage/s3` | ||
| - `remix/form-data-middleware` → `remix/middleware/form-data` | ||
| - `remix/logger-middleware` → `remix/middleware/logger` | ||
| - `remix/method-override-middleware` → `remix/middleware/method-override` | ||
| - `remix/render-middleware` → `remix/middleware/render` | ||
| - `remix/session-middleware` → `remix/middleware/session` | ||
| - `remix/session-storage-memcache` → `remix/session-storage/memcache` | ||
| - `remix/session-storage-redis` → `remix/session-storage/redis` | ||
| - `remix/session/cookie-storage` → `remix/session-storage/cookie` | ||
| - `remix/session/fs-storage` → `remix/session-storage/fs` | ||
| - `remix/session/memory-storage` → `remix/session-storage/memory` | ||
| - `remix/static-middleware` → `remix/middleware/static` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "remix/data-table/$1": "@remix-run/data-table-([a-z0-9-]+)", | ||
| "remix/file-storage/$1": "@remix-run/file-storage-([a-z0-9-]+)", | ||
| "remix/middleware/$1": "@remix-run/([a-z0-9-]+)-middleware", | ||
| "remix/router": "@remix-run/fetch-router", | ||
| "remix/routes": "@remix-run/fetch-router/routes", | ||
| "remix/session": "@remix-run/session", | ||
| "remix/session-storage/$1": "@remix-run/session-storage-([a-z0-9-]+)", | ||
| "remix/session-storage/cookie": "@remix-run/session/cookie-storage", | ||
| "remix/session-storage/fs": "@remix-run/session/fs-storage", | ||
| "remix/session-storage/memory": "@remix-run/session/memory-storage" | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.