Skip to content

fix(types): Add missing type def for future value in @remix-run/dev/server-build - #4771

Merged
chaance merged 1 commit into
mainfrom
chance/fix-missing-type
Dec 5, 2022
Merged

chaance merged 1 commit into
mainfrom
chance/fix-missing-type

Conversation

@chaance

@chaance chaance commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

This should fix #4766. Unrelated to #4759.

Changeset will be added to the release branch @brophdawg11 started. Aiming to cut a hotfix shortly.

@changeset-bot

changeset-bot Bot commented Dec 5, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3287bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey

MichaelDeBoey commented Dec 5, 2022 •

Copy link
Copy Markdown
Member

I think this should go to dev branch instead of main? 🤔
Or does remix-run/react-router#9679 apply here as well?

@chaance

chaance commented Dec 5, 2022

Copy link
Copy Markdown
Contributor Author

I think this should go to dev branch instead of main? 🤔

Hot-fixes actually go to main to avoid releasing other work on dev early. We need to prioritize this fix along with some router stuff @brophdawg11 is finishing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property 'future' is missing in type 'typeof import("./node_modules/@remix-run/dev/server-build")'

3 participants