feat: CSS side effect imports - #4919
Merged
Merged
Conversation
Co-authored-by: Chance Strickland <hi@chance.dev>
Co-authored-by: Chance Strickland <hi@chance.dev>
Co-authored-by: Chance Strickland <hi@chance.dev>
Co-authored-by: Chance Strickland <hi@chance.dev>
Co-authored-by: Chance Strickland <hi@chance.dev>
Co-authored-by: Chance Strickland <hi@chance.dev>
mjackson
approved these changes
Dec 22, 2022
markdalgleish
marked this pull request as ready for review
January 4, 2023 00:31
Contributor
|
🤖 Hello there, We just published version Thanks! |
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4817
Testing Strategy:
There is an integration test covering the build pipeline to ensure that all relevant styles end up on the page.
There's also a suite of unit tests to validate that CSS side effect imports are detected and annotated correctly for different usages of
require/import.I also trialled this in a playground using both uikit-test-using-css and React Spectrum that were referenced in the original issue: #2469