initial work on clientLoader & clientAction#5543
Conversation
|
brophdawg11
left a comment
brophdawg11
left a comment
There was a problem hiding this comment.
So pumped for this 🤩
| response instanceof Response && | ||
| response.headers.get("X-Remix-Redirect") != null | ||
| (response.headers.get("X-Remix-Redirect") != null || | ||
| (response.status >= 300 && response.status < 400)) |
There was a problem hiding this comment.
We can steal this util from RR (or even export it as UNSAFE_ and use it directly:
const redirectStatusCodes = new Set([301, 302, 303, 307, 308]);
export function isRedirectStatusCode(statusCode: number): boolean {
return redirectStatusCodes.has(statusCode);
}There was a problem hiding this comment.
Is the reason we need this because clientLoader doesn't run through the internal checking? Maybe we can get rid of the need for this an put less in the doFetch...
There was a problem hiding this comment.
The reason we need this is because Remix is expecting a 204 response to represent redirects and we don't currently handle real redirect responses.
| export interface ClientDataFunctionArgs { | ||
| request: Request; | ||
| params: Params; | ||
| next: () => Promise<Response | DeferredData | null>; |
There was a problem hiding this comment.
We can bikeshed this as we go - I like serverFetch at the moment
| let doFetch = async (request: Request) => { | ||
| if (isAction && !route.hasAction) { | ||
| let msg = | ||
| `Route "${route.id}" does not have an action, but you are trying ` + | ||
| `to submit to it. To fix this, please add an \`action\` function to the route`; | ||
| console.error(msg); | ||
| throw new Error(msg); | ||
| } else if (!isAction && !route.hasLoader) { | ||
| return null; | ||
| } | ||
|
|
||
| let result = await fetchData(request, route.id); |
There was a problem hiding this comment.
I wonder if doFetch could stop here so we get all the same error/redirect/catch handling whether they hit the server or not?
github-actions
Bot
added
the
needs-response
machour
removed
the
needs-response
|
I'm gonna close this out for now - we can re-open if needed once we start on v3 features |
3 participants
Closes: #5070
Testing Strategy: