fix: revert browserRouteModulesPlugin - #5721
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 225716c The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MichaelDeBoey
approved these changes
Mar 8, 2023
fix: put new browserRouteModulesPlugin behind `config.future.unstable_dev`
jacob-ebey
force-pushed
the
client-route-modules
branch
from
March 8, 2023 22:27
a21223c to
225716c
Compare
Contributor
|
🤖 Hello there, We just published version Thanks! |
This was referenced Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: put new browserRouteModulesPlugin behind
config.future.unstable_devThis fixes an issue that arose because of using AST parsing to strip route module exports. Reverting to previous way for now and will work on a fix behind the unstable_dev flag.
Closes: #
Testing Strategy:
New integration tests.