Skip to content

fix(dev): treat imported assets from node_modules as external - #6813

Merged
pcattori merged 6 commits into
remix-run:devfrom
lpsinger:fix-import-svg-from-node-modules
Aug 8, 2023
Merged

pcattori merged 6 commits into
remix-run:devfrom
lpsinger:fix-import-svg-from-node-modules

Conversation

@lpsinger

@lpsinger lpsinger commented Jul 12, 2023 •

Copy link
Copy Markdown
Contributor

Closes #1909

  • Docs
  • Tests

Testing Strategy: added an integration test

@changeset-bot

changeset-bot Bot commented Jul 12, 2023 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f9bd868

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey linked an issue Aug 6, 2023 that may be closed by this pull request
Comment thread integration/svg-in-node-modules-test.ts Outdated
Comment thread integration/svg-in-node-modules-test.ts Outdated
lpsinger and others added 3 commits August 6, 2023 23:01
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@pcattori
pcattori merged commit 9953532 into remix-run:dev Aug 8, 2023
@lpsinger
lpsinger deleted the fix-import-svg-from-node-modules branch August 8, 2023 19:13
@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

lpsinger added a commit to lpsinger/remix that referenced this pull request Aug 16, 2023
brophdawg11 added a commit that referenced this pull request Aug 16, 2023
Co-authored-by: Matt Brophy <matt@brophy.org>
lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Sep 25, 2023
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
lpsinger added a commit to nasa-gcn/gcn.nasa.gov that referenced this pull request Sep 25, 2023
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
Vidushi-GitHub pushed a commit to Vidushi-GitHub/gcn.nasa.gov that referenced this pull request Oct 11, 2023
This workaround is no longer needed because
remix-run/remix#6813 has been fixed
upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Merged

Development

Successfully merging this pull request may close these issues.

Importing PNG/SVG from node_modules failing

4 participants