Skip to content

fix(remix-dev/vite): remove Vite wrapper functions - #8120

Merged
markdalgleish merged 5 commits into
devfrom
markdalgleish/remove-vite-wrapper-functions
Nov 26, 2023
Merged

markdalgleish merged 5 commits into
devfrom
markdalgleish/remove-vite-wrapper-functions

Conversation

@markdalgleish

@markdalgleish markdalgleish commented Nov 24, 2023 •

Copy link
Copy Markdown
Member

Based on a suggestion by @pcattori, this PR removes the indirection of calling out to Vite via Remix APIs. Instead, we now keep the API surface area as small as possible and get consumers using custom servers to interact with Vite directly.

@changeset-bot

changeset-bot Bot commented Nov 24, 2023 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0709ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Definitely better than what we had before IMO.

One thing I'm debating now is whether it makes sense to inline a small utility in server.mjs just to clean up the ternary / .then(...) logic. Something like:

// server.mjs
async function createViteServer() {
  if (process.env.NODE_ENV === "production") return undefined
  let { createServer } = await import("vite")
  return createServer({
    server: {
      middlewareMode: true
    }
  })
}

let vite = await createViteServer()

if (vite) {
  /* ... */
}
// etc.

To be clear, this is not API we would maintain and export, but rather just code we include as part of the examples/templates to make things a bit easier to follow.

Naming tbd. E.g. could be let dev = await createDev() instead. Not sure what I prefer.


Update: the more I look at this the more I prefer the existing "just inline it all" solution. No need to choose good names for abstractions that don't exist!

@markdalgleish
markdalgleish merged commit 497eea8 into dev Nov 26, 2023
@markdalgleish
markdalgleish deleted the markdalgleish/remove-vite-wrapper-functions branch November 26, 2023 20:20
@github-actions

github-actions Bot commented Dec 5, 2023

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version 2.4.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version 2.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants