Always ignore route files starting with . - #8801
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 74cda7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
approved these changes
Feb 20, 2024
pcattori
marked this pull request as draft
February 20, 2024 17:15
pcattori
marked this pull request as ready for review
February 20, 2024 17:16
pcattori
force-pushed
the
markdalgleish/ignore-route-dotfiles
branch
5 times, most recently
from
February 20, 2024 18:49
0b8bbac to
4df8b3d
Compare
pcattori
force-pushed
the
markdalgleish/ignore-route-dotfiles
branch
from
February 20, 2024 19:31
096d8e8 to
74cda7d
Compare
Contributor
|
🤖 Hello there, We just published version Thanks! |
Contributor
|
🤖 Hello there, We just published version Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is in response to the following issue: #8744
Having dotfiles like
.DS_Storein the routes directory causes hard-to-debug errors when"**/.*"is not configured inignoredRouteFiles. This is particularly notable when using the Vite plugin since we've encourage usage without any config (i.e.remix()in the plugins array). Currently none of the Vite templates haveignoredRouteFilesset.Since we've moved to flat routes, it no longer makes sense to have route files starting with a
.character since it's meant to be a delimiter denoting a/in the URL. As a result, rather than doubling down and addingremix({ ignoredRouteFiles: ["**/.*"] })to all Vite templates, it makes more sense to always ignore route files starting with..The bulk of this PR is just updating docs and templates now that it's redundant to add
**/.*toignoredRouteFiles.